PR 1262 review: BGP Speaker under Overlay Networks › Settings

Our own draft PR, reviewed before marking it ready. Two independent passes (Cody's process and ours), merged. Preview built from 3c9727b against .105 with every write held in the browser; baseline harvester-main rebuilt from upstream main 97ce1e9. Nothing was written to .105 or posted on GitHub.

Round two (final, 17 Nov): ready for review. Both passes re-ran on the rebased head (436eab6, main 6a20578): the six round-1 fixes hold, #3 (menu entry on pre-v1.10) was decided as keep (noted in the PR), and the only new point (two exports nothing imports) is fixed in 24dfdc4. PR is mergeable again; it stays a draft until the Kube-OVN bump (harvester 12291) lands.

Round two

#Round-1 findingPass A (Cody's new-commits)Pass B (fresh agent)
1Failed read: blank page / "Disabled"Addressed (live)Fixed (live, 403 and 404)
2Add-on link to the fail-whaleAddressed (live)Fixed (live, both pages)
3Settings entry before v1.10.0-Unchanged; decided: keep
4Hardcoded product name-Fixed (renders "Harvester")
5Subnet warning placement-Fixed (under the radio, DHCP margins)
6Duplicate parsingAddressed (code + live load)Fixed
7"local" comment and tooltip-Fixed
newsplitList / PLACEHOLDER_NEIGHBORS exported but unused (nit)not foundFound; fixed in 24dfdc4

Also checked in round two: the rebase changed only the feature-flag line; held saves (enable with one host, disable, subnet annotation add/remove); Save disabled with no host, a bad neighbor, or a router ID with two hosts; a read-only user gets View Setting with no Save; .105 unchanged at the end. Cost: Pass B 17 min, 67 tool uses, ~208k tokens; Pass A in this session.

Round one (16 Nov, 3c9727b), kept below. Original verdict: needs small changes. No blockers. Two bugs to fix (a failed load shows a blank page / a wrong "Disabled"; a broken add-on link on the BGP page), four suggestions (pre-v1.10 menu entry, product-name token, warning placement, duplicate parsing) and one nit. Everything the issue and the PR thread ask for works, except next hops as a list, which waits on rrajendran17. Three questions for the backend owner.

The two passes

Pass A (Cody's process, ai-skills c04c11a)Pass B (our process, fresh agent)
Findings2 bugs + 1 duplication (after verify / refine / condense / preexisting)4 suggestions + 1 nit + 3 questions
Checked by bothBlank BGP page on a failed read (B also caught the card's "Disabled"); acceptance; held PUT bodies; subnet annotation; keyboard path to the card menu
Only this passBroken add-on link from the BGP page; duplicate parsing; axe run (pre-existing hits removed); before/after videosPre-v1.10 menu entry; product-name token; warning placement; "local" comment; NAT Outgoing doc; IPv6 placeholder
MissedThe four Pass B suggestions/nitThe add-on link (it opened the banner but didn't follow the link); the duplication
OutputCriteria, verification table, 3 comments, pre-existing list, 2 videosreview.md, coverage grid, checked list, draft, 30 screenshots
CostIn this session, about 40 min27 min, 88 tool uses, ~266k tokens

Findings (merged, each re-checked)

1Should fixBoth passes

A failed read of the Kube-OVN Configuration: the BGP Speaker page goes blank, and the Settings card says "Disabled" under the error

The page keeps the error in errors, but only the form shows errors, and the form only renders after a successful load (bgp.vue:337). The card falls back to generic.disabled when nothing loaded. A transient API error or a missing object reads as "BGP is off" on one page and as an empty page on the other. No test covers it.

Re-checked: live (GET answered 403 / 404 in the browser). | Fixed in 436eab6: Rechecked live: with the read answered 403, the BGP page shows the error message and the card says Unknown. Unit test added; it fails without the fix.

BGP Speaker page with the Configuration read failing: only the title
BGP Speaker page with the Configuration read failing: only the title
Settings: the error banner, and the card still says Disabled
Settings: the error banner, and the card still says Disabled
2Should fixPass A only

The "add-on is not enabled" link on the BGP Speaker page lands on the fail-whale

The link is the relative path harvesterhci.io.addon/kube-system/kubeovn-operator?mode=edit (bgp.vue:81). On the Settings page it resolves to the add-on, but the BGP page sits one level deeper, so it opens /overlay-network-settings/harvesterhci.io.addon/kube-system/kubeovn-operator, which no route matches. Pass B saw this banner but did not follow the link.

Re-checked: live (add-on shown disabled in the browser): Settings page link opens the add-on, BGP page link lands on /fail-whale. | Fixed in 436eab6: Rechecked live: both pages' links open the kubeovn-operator add-on (named route). Unit test added.

BGP Speaker page with the add-on shown disabled
BGP Speaker page with the add-on shown disabled
After clicking "here": /fail-whale, blank
After clicking "here": /fail-whale, blank
3SuggestionPass B only

On Harvester before v1.10.0, Overlay Networks still gets a Settings entry whose only card says the speaker needs v1.10.0

The menu entry only checks that the Configuration type exists (harvester-cluster.js:922), and that CRD exists on older Kube-OVN add-ons too. Elsewhere the extension hides version-gated features: none of main's 46 getFeatureEnabled uses shows a "requires version" message, and this same PR hides the subnet BGP option on those versions. Note: the shell's menu entries can't check a Harvester feature flag directly (only types, Rancher features and fixed capabilities), so this is a design point, not a one-liner.

Re-checked: live (server version faked to v1.9.0 in the browser) and code. | Decided 17 Nov: keep: A shell menu entry cannot check the Harvester version (only types, a fixed capability list, Rancher feature flags); only Rancher users managing a v1.6-v1.9 cluster with the v1.10 extension see it, and the card says why. Noted in the PR description.

v1.9.0: Settings entry present, the card only says it needs v1.10.0
v1.9.0: Settings entry present, the card only says it needs v1.10.0
4SuggestionPass B only

The new "requires Harvester v1.10.0" message hardcodes the product name

en-us.yaml:1516 says "Harvester", while main writes the product name as the [[Harvester]] token in all 55 places and has no plain "Harvester v…" left. The token is what shows "SUSE Virtualization" on Rancher Prime, so this would be the one string that still says Harvester there.

Re-checked: code (token count on main 55, plain 0). | Fixed in 436eab6: Rechecked live: the v1.9 message renders the product token ("Harvester" on this standalone UI).

5SuggestionPass B only

On the subnet form, the BGP warning sits in its own column next to the radio; the DHCP banner on the same form sits under its radio

BGP: a second col span-6 beside the RadioGroup (subnet index.vue:428). DHCP: the Banner inside the RadioGroup's own column (index.vue:347-385). With both on, help tied to a radio shows in two different places one section apart.

Re-checked: code and live. | Fixed in 436eab6: Rechecked live: the warning now sits under the BGP radio, in its column, like the DHCP banner.

Subnet form: DHCP banner under its radio, BGP warning to the right of its radio
Subnet form: DHCP banner under its radio, BGP warning to the right of its radio
6SuggestionPass A only

The BGP page re-parses what the new model already parses

bgp.vue:151 splits the neighbor and next-hop strings and filters the placeholder addresses again, while the model's bgpNeighbors / bgpNextHops getters (model:26) already do. The placeholder rule lives in two places.

Re-checked: code. | Fixed in 436eab6: Rechecked live: stored values load through the model getters; the held save sends the same spec.bgp.

7NitPass B only

The subnet getter's comment says Kube-OVN's "local" advertises the subnet; it only announces pod IPs from the hosts running them

kube-ovn pkg/speaker/subnet.go (release-1.17): cluster (and true) announce the subnet CIDR; local makes the Pod IPs be announced only from speakers on nodes hosting them. A local subnet reads as Enabled, which is right, but the comment and the tooltip ("Advertise this subnet's CIDR block") are wrong for it. Only touches annotations set outside the UI.

Re-checked: kube-ovn source. | Fixed in 436eab6: Comment corrected; the tooltip now reads "Advertise this subnet to the BGP neighbors set in Overlay Networks > Settings."

Questions

Pass A: demos

Before this change (main):

With this change (PR preview, save held in the browser):

Pass A: acceptance

Criterion (issue + rrajendran17's comments)Verdict
AC1BGP config under Overlay Networks at NAT & Internet's level, not in the add-onMet
AC2Node names (several), neighbor AS, cluster AS, neighbor addresses, optional next hops and router IDMet
AC3Save writes spec.bgp of kube-system/kubeovn and nothing elseMet (other 31 spec keys identical)
AC4Neighbor v4, v6 and next hops each take more than one valueNeighbors met; next hops = open question
AC5Subnet BGP option adds / removes ovn.kubernetes.io/bgp: "true"Met (enable, disable, "local" kept)
AC6Existing flows unchangedMet (subnet DHCP defaults are main's own; add-on = main)
AC7No BGP config offered on versions without supportMet in the forms (see finding 3 for the menu)

Removed as pre-existing on main: axe target-size on the shell's tooltip buttons (main's Schedule VM Backup form has the same), and the RadioGroup's aria-toggle-field-name.

What we decided to change (done in c4a98c4, except 3)

  1. Show a failed Configuration load as an error on the BGP page, and don't show "Disabled" on the card when nothing loaded (findings 1).
  2. Fix the add-on link on the BGP page (2).
  3. Decide on the pre-v1.10 menu entry (3), then fix the product name in whatever message stays (4).
  4. Put the subnet BGP warning under its radio, like DHCP (5).
  5. Have the page use the model's getters (6) and correct the "local" comment and tooltip (7).

Not posted anywhere. Built 2026-11-17 13:47 UTC.